-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO NEED TO REVIEW NOW] Feature/entry widget and secure conversations v2 #1133
Draft
andrews-moc
wants to merge
108
commits into
development
Choose a base branch
from
feature/entry-widget-and-secure-conversations-v2
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[NO NEED TO REVIEW NOW] Feature/entry widget and secure conversations v2 #1133
andrews-moc
wants to merge
108
commits into
development
from
feature/entry-widget-and-secure-conversations-v2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavDo
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
November 1, 2024 11:12
8ae0b3e
to
c866c9d
Compare
DavDo
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
November 18, 2024 21:27
d5f11d7
to
4482f85
Compare
andrews-moc
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
November 27, 2024 12:54
420a67a
to
7083628
Compare
gugalo
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
2 times, most recently
from
December 13, 2024 13:01
2741376
to
c55758d
Compare
andrews-moc
force-pushed
the
development
branch
from
December 27, 2024 13:01
beff537
to
da6cfc5
Compare
andrews-moc
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
December 27, 2024 13:10
ae3c8f4
to
274f4c5
Compare
- Migrate Call and Chat Activities to Kotlin - Refactor CallConfiguration - Refactor EngagementConfiguration MOB 3587
- Moved all the Intent-related functionality to the IntentHelper class. - Abstraction will let us to easily mock this layer. MOB 3582
- Create ActivityLauncher - Rename FilePreview... classes to ImagePreview... MOB 3589
- Create interfaces for EngagementLauncher - Create basic ConfigurationManager that should hold all the init config MOB 3588
This custom attributes can be setup by integrators in their theme.xml
This is needed so that customise glia theme settings in integrators theme.xml
- Remove all the configurations in favor of ConfigurationManager - Get rid of configurations passed through Activity extras - Move extra keys to internal class - Make activities internal - Minor refactoring
Texts have changed, updating according to the Figma designs. MOB-3615
…idget Setup queues each time get Entry Widget is called MOB-3408
…g to design MOB-3478
…led in Example App settings MOB-3657
…is not authenticated MOB-3659
The old staging version of Core SDK got automatically deleted for some reason. Discussion in slack: https://salemove.slack.com/archives/C01F9K88SQZ/p1732545132319779?thread_ts=1732527166.629109&cid=C01F9K88SQZ
In some places the Observable#timeout() had unwanted results. Specifically: - It terminated observable breaking delivery of events after the timeout triggered - Plan was for it to fire timeout exception only if there was no previous event but it also triggered even when there was valid values. MOB-3839
MOB-3845
Side effect of making the layout flat is that now those buttons have slight animation. MOB-3844
Last Core SDK staging build got expired/deleted so uploaded new build
- Added inputDisabled Json to UI remote theme configurations - Switched simple color/drawables to ColorStateList/DrawableStateList MOB-3855
Remove SecureFileAttachmentRepository and some SC use cases that duplicated the logic. Refactor FileAttachmentRepository and the file upload use cases. FileAttachmentRepository is used for both SC and Live Engagement. MOB-3791
Issue introduced in #1183
Do not start a timer for marking messages as read if the leave secure conversation dialog is shown. MOB-3833
…type or starts a new engagement during queueing MOB-3886
andrews-moc
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
December 27, 2024 15:56
2ca729a
to
35d6916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-xxx
What was solved?
Release notes:
Additional info:
Screenshots: