Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO NEED TO REVIEW NOW] Feature/entry widget and secure conversations v2 #1133

Draft
wants to merge 108 commits into
base: development
Choose a base branch
from

Conversation

andrews-moc
Copy link
Contributor

Jira issue:
https://glia.atlassian.net/browse/MOB-xxx

What was solved?

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKsThings to consider for newly added logs in Confluence for more information.

Screenshots:

@DavDo DavDo force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 8ae0b3e to c866c9d Compare November 1, 2024 11:12
@DavDo DavDo force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from d5f11d7 to 4482f85 Compare November 18, 2024 21:27
@andrews-moc andrews-moc force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 420a67a to 7083628 Compare November 27, 2024 12:54
@gugalo gugalo force-pushed the feature/entry-widget-and-secure-conversations-v2 branch 2 times, most recently from 2741376 to c55758d Compare December 13, 2024 13:01
@andrews-moc andrews-moc force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from ae3c8f4 to 274f4c5 Compare December 27, 2024 13:10
DavDo and others added 23 commits December 27, 2024 17:33
- Migrate Call and Chat Activities to Kotlin
- Refactor CallConfiguration
- Refactor EngagementConfiguration

MOB 3587
- Moved all the Intent-related functionality to the IntentHelper class.
- Abstraction will let us to easily mock this layer.

MOB 3582
- Create ActivityLauncher
- Rename FilePreview... classes to ImagePreview...

MOB 3589
- Create interfaces for EngagementLauncher
- Create basic ConfigurationManager that should hold all the init config

MOB 3588
This custom attributes can be setup by integrators in their theme.xml
This is needed so that customise glia theme settings in integrators theme.xml
- Remove all the configurations in favor of ConfigurationManager
- Get rid of configurations passed through Activity extras
- Move extra keys to internal class
- Make activities internal
- Minor refactoring
Texts have changed, updating according to the Figma designs.

MOB-3615
…idget

Setup queues each time get Entry Widget is called

MOB-3408
DavDo and others added 29 commits December 27, 2024 17:35
The old staging version of Core SDK got automatically deleted for some reason.

Discussion in slack:
https://salemove.slack.com/archives/C01F9K88SQZ/p1732545132319779?thread_ts=1732527166.629109&cid=C01F9K88SQZ
In some places the Observable#timeout() had unwanted results. Specifically:
- It terminated observable breaking delivery of events after the timeout triggered
- Plan was for it to fire timeout exception only if there was no previous event but it also triggered even when there was valid values.

MOB-3839
Side effect of making the layout flat is that now those buttons have slight animation.

MOB-3844
Last Core SDK staging build got expired/deleted so uploaded new build
- Added inputDisabled Json to UI remote theme configurations
- Switched simple color/drawables to ColorStateList/DrawableStateList

MOB-3855
Remove SecureFileAttachmentRepository and some SC use cases that duplicated the logic.
Refactor FileAttachmentRepository and the file upload use cases. FileAttachmentRepository is used for both SC and Live Engagement.

MOB-3791
Do not start a timer for marking messages as read if the leave secure conversation dialog is shown.

MOB-3833
…type or starts a new engagement during queueing

MOB-3886
@andrews-moc andrews-moc force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 2ca729a to 35d6916 Compare December 27, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants